Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to functions related to data_vars #8226

Merged
merged 8 commits into from
Sep 24, 2023

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Sep 22, 2023

A smaller PR related to trying to pass T_DuckArray's along xarray's different classes.

@Illviljan Illviljan marked this pull request as ready for review September 23, 2023 09:26
@Illviljan Illviljan changed the title Add type hints in dataset Add typing to function related to data_vars Sep 23, 2023
@Illviljan Illviljan changed the title Add typing to function related to data_vars Add typing to functions related to data_vars Sep 23, 2023
Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good start :)

xarray/core/dataset.py Outdated Show resolved Hide resolved
xarray/core/dataset.py Show resolved Hide resolved
xarray/core/types.py Show resolved Hide resolved
@headtr1ck headtr1ck added the plan to merge Final call for comments label Sep 24, 2023
@Illviljan Illviljan merged commit 77eaa8b into pydata:main Sep 24, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments topic-typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants